-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: replace padding values with logical properties #774
Accessibility: replace padding values with logical properties #774
Conversation
|
|
…s_with_logical_properties
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI Magda. All looks good - just one question! thanks
padding: $space-0-5; | ||
padding-top: $space-0-25; | ||
padding-inline: $space-0-5; | ||
padding-block-start: $space-0-25; | ||
box-sizing: border-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking but will padding: $space-0-5
apply padding to top, right, bottom and left; then padding-top
adds an extra 0-25 to the top?
so would this need to be:
padding-inline: $space-0-5;
padding-block-end: $space-0-5;
padding-block-start: $space-0-75;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced that with correct values, thank you for spotting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Magda. Does padding-block: $space-0-25 $space-0-5;
need to be padding-block: $space-0-75 $space-0-5;
?
I think the original applies $space-05
to all sides, then an additional $space-0-25
to the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where this $space-0-75
coming from? The original, as you mentioned, applies $space-05
to all sides and we have override the top with $space-0-25
, which is the equivalent of padding-top: $space-0-25; padding-right: $space-0-5; padding-bottom: $space-0-5; padding-left: $space-0-5;
so it translates to padding-block: $space-0-25 $space-5;
and padding-inline: $space-0-5;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, perhaps I misunderstood. I didn't realise that padding-top
overrides the padding: I thought it added to it!
|
…s_with_logical_properties
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
closes #773